JDownloader Community - Appwork GmbH
 

Notices

Reply
 
Thread Tools Display Modes
  #1  
Old 17.10.2009, 22:04
GNCMatt
Guest
 
Posts: n/a
Default Incorrect Container Naming

I've noticed over the past few days, if a file is named something.part1.rar, something.part2.rar, etc. the container doesn't get named properly.

For example if you have: "This.Is.A.Test.part1.rar" the container will be named "This" instead of "This.Is.A.Test"

Not sure if this had been reported already or not, but thought I'd throw it out there just in case.

Last edited by Jiaz; 18.10.2009 at 04:04.
Reply With Quote
  #2  
Old 18.10.2009, 00:22
GNCMatt
Guest
 
Posts: n/a
Default

Sorry I was wrong, it's not because of part1.rar stuff.

pat10, which is "(.*)\\.[_a-z]{3}(\\.|$)"

It's grabbing any 3 letter's in the name beginning with and ending in . and calling it the end.

So This.and.that.rar would detect the .and. and call the package This

I don't know much about FFSJ but a quick search makes it look like extensions are like .__a .__b, etc. So I'm not sure why it checks for the trailing period, so maybe it should be "(.*)\\.[_a-z]{3}$" instead?

Though another potential problem if that were changed could be a file free.hat.rar, it would first strip the .rar at pattern 3, then strip .hat at pattern 10. So calling pattern 10 before pattern 3 may fix that.

I didn't test most of this, just theory. I don't have a commit account anyway so I figured this was enough to explain it to someone that does.
Reply With Quote
  #3  
Old 18.10.2009, 04:04
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

can you pm me some example links?
__________________
JD-Dev & Server-Admin
Reply With Quote
  #4  
Old 18.10.2009, 13:11
remi
Guest
 
Posts: n/a
Cool

Quote:
Originally Posted by GNCMatt View Post
Sorry I was wrong, it's not because of part1.rar stuff.

pat10, which is "(.*)\\.[_a-z]{3}(\\.|$)"

It's grabbing any 3 letter's in the name beginning with and ending in . and calling it the end.

So This.and.that.rar would detect the .and. and call the package This

I don't know much about FFSJ but a quick search makes it look like extensions are like .__a .__b, etc. So I'm not sure why it checks for the trailing period, so maybe it should be "(.*)\\.[_a-z]{3}$" instead?

Though another potential problem if that were changed could be a file free.hat.rar, it would first strip the .rar at pattern 3, then strip .hat at pattern 10. So calling pattern 10 before pattern 3 may fix that.

I didn't test most of this, just theory. I don't have a commit account anyway so I figured this was enough to explain it to someone that does.
You refer to patterns. Where did you get these? I suppose they aren't yours, as you refer to a numbering system.
Reply With Quote
  #5  
Old 18.10.2009, 16:51
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

these are from sourcecode;)
__________________
JD-Dev & Server-Admin
Reply With Quote
  #6  
Old 19.10.2009, 01:27
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

please give me some example links, because your example from above works for me.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #7  
Old 19.10.2009, 09:02
GNCMatt
Guest
 
Posts: n/a
Default

Alright PM'd you some specific ones that gave me issues.
Reply With Quote
  #8  
Old 19.10.2009, 16:57
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

i changed regex a little and now your links work fine, please verify
__________________
JD-Dev & Server-Admin
Reply With Quote
  #9  
Old 19.10.2009, 19:28
GNCMatt
Guest
 
Posts: n/a
Default

Looks good, requiring the initial underscore should significantly decrease the chances of false positives, especially in my case. Thanks!
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 07:33.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.