JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 15.07.2022, 00:07
svArtist's Avatar
svArtist svArtist is offline
DSL Light User
 
Join Date: Mar 2015
Posts: 30
Lightbulb Extend Bandcamp plugin for embedded player URLs

Today Google sent me to a view of Bandcamp's "**External links are only visible to Support Staff**embedded player" and JD didn't know what to do with it.
(outdated, see below. Just leaving it in here in case it becomes useful I don't know how the crawler works, but if the lazy loading is an issue (or JS can't parse that page for another reason) and the album ID in the URL can't be used to get to the familiar album page, these embed pages seem to contain a reference to the regular album page:
Either in the sharing widget
HTML Code:
<div id="sharedialog" title="Share">
  <p>
    <a href="**External links are only visible to Support Staff** target="_blank">Embed this album[...]</a>
[...]
-> something like
Code:
$("#sharedialog>p>a")[0].href.match(/(.+)\?/)
should do the trick?
Or the loading script
HTML Code:
<script type="text/javascript" src="**External links are only visible to Support Staff** crossorigin="anonymous" nonce="gm6uKUDmFnIMq7HTyO1bpA==" data-player-data="{&quot;linkback&quot;:&quot;**External links are only visible to Support Staff**></script>
->
Code:
$("script[data-player-data*='.bandcamp.com/album/']").attr("data-player-data").match(/"(https?:\/\/[^\s?&\/]+\.bandcamp\.com\/album\/[^\s?&\/]+?)"/)
)

Holy shit, that's a long list of arguments.
Hold on, the individual songs are also listed in there

Code:
JSON.parse($("script[data-player-data*='.bandcamp.com/album/']").attr("data-player-data")).tracks
gives you a neat array of objects containing file URLs and metadata <3
Code:
{
	"file": {
		"<format, like 'mp3-128'>": string
	},
	"track_streaming": boolean,
	"tracknum": number,
	"title_link": string,
	"preorder_download_track": boolean,
	"id": number,
	"encodings_id": number,
	"art_id": ?,
	"artist": string,
	"title": string,
	"duration": number
}
Reply With Quote
  #2  
Old 15.07.2022, 10:19
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 80,466
Default

@svArtist: so you're asking to add support for embedded player url format, so you can just copy that url and let JDownloader do its work?
so we can add support for bandcamp.com/EmbeddedPlayer.html... urls
__________________
JD-Dev & Server-Admin
Reply With Quote
  #3  
Old 15.07.2022, 12:39
pspzockerscene's Avatar
pspzockerscene pspzockerscene is online now
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 72,065
Default

Added support for such URLs.

Bitte auf das nächste CORE-Update warten!

Please wait for the next CORE-Update!

Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!


-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #4  
Old 16.07.2022, 22:59
svArtist's Avatar
svArtist svArtist is offline
DSL Light User
 
Join Date: Mar 2015
Posts: 30
Default

Oh, that was fast!
I was just about to reply to the first message, then I saw the second one

Thank youuu <3
Reply With Quote
  #5  
Old 29.08.2022, 16:29
pspzockerscene's Avatar
pspzockerscene pspzockerscene is online now
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 72,065
Default

CORE-Updates have been released!
All announced bugfixes and features are live!
Please update your JDownloader and report any issues you find asap.

CORE-Updates wurden released!
Alle angekündigten Bugfixes/Features sind nun verfügbar!
Bitte JDownloader updaten und eventuelle Bugs schnellstmöglich an uns melden.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #6  
Old 29.08.2022, 16:36
svArtist's Avatar
svArtist svArtist is offline
DSL Light User
 
Join Date: Mar 2015
Posts: 30
Default

Quote:
Originally Posted by pspzockerscene View Post
CORE-Updates have been released!
All announced bugfixes and features are live!
Please update your JDownloader and report any issues you find asap.

CORE-Updates wurden released!
Alle angekündigten Bugfixes/Features sind nun verfügbar!
Bitte JDownloader updaten und eventuelle Bugs schnellstmöglich an uns melden.

-psp-
Beautiful!
Tested and confirmed for this one
Reply With Quote
  #7  
Old 29.08.2022, 16:38
pspzockerscene's Avatar
pspzockerscene pspzockerscene is online now
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 72,065
Default

Thanks for your feedback!
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 13:56.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.