[StefanM]

Originally Posted by Jiaz

those are placeholder for the "Copy information* and has nothing to do with scripts for Eventscripter. There you have access to the number and have to convert to human readable string by yourself
those placeholder is formatted filesize in different units

Yes, but you said before

Originally Posted by Jiaz
for example? The ones from "Copy Information" coincidentally sound the same.

and I just replied "No"...
(I meant, that they don't sound the same)

[Jiaz]

Originally Posted by StefanM

I meant, that they don't sound the same

Because I thought you were looking for those placeholder within the eventscripter script. and that they sound *the same* between scripts and *Copy information* and yet not available

[StefanM]

Originally Posted by pspzockerscene

And?
Why would you read the "Add custom EventScripter buttons" article first without even knowing what the EventScripter is?..

Hey!!!
No need to shout at me.

A user (like me) possibly - but not necessarily - would have read the first article. But you cannot assume that! In fact I read it a few days before. And then some other day I read the article I was referring to in my post. And yes, I did not have Script Eventer installed.

I can look back on decades of experience with customers, as any complaints about our technical support finally ended up on my desk.

Please believe me, when I say, that you cannot assume that a user would read both articles. Nor can you assume that they would read both of them on the same occasion.

Of course there is no need to rewrite everything in every article. But a reference "Please make sure that you have Script Eventer Extension installed as described here..." does make sense.

You are sharing a lot of your experience with me and other users here. And you are doing a great job!

I just wanted to share some of my experience with you, to help you, to give you at least something back. That's all.


Just take a lot at some User's Manuals, maybe of your TV, your Stereo, your automatic lawnmower, whatsoever. If it is no a 'cheap' Chinese product, you will notice, that in each chapter (how to do this, how to do that,...) you will find references:

"Before you start, make sure that you..."

That's all I wanted to tell you.

[pspzockerscene]

Originally Posted by StefanM

No need to shout at me.

No shouting involved.

Originally Posted by StefanM

And yes, I did not have Script Eventer installed.

Sure you can also read the article without having the EventScripter installed but it should be a logical thing that in order to be able to use it, you need to install it. As said, a sentence with that same meaning is now included in the "What is the EventScripter" article.

Originally Posted by StefanM

Please believe me, when I say, that you cannot assume that a user would read both articles. Nor can you assume that they would read both of them on the same occasion.

Yes I believe you but then that user will either not use the EventScripter at all or he will ask us.
The latter case has so far never happened

Originally Posted by StefanM

Of course there is no need to rewrite everything in every article. But a reference "Please make sure that you have Script Eventer Extension installed as described here..." does make sense.

Disagree. As said if that made sense, you'd have to cross link every instructions article from every other article.
This would also mean that, for every example of LinkCrawler Rules, we'd have to link that:
https://support.jdownloader.org/Know...kcrawler-rules
E.g.:
https://support.jdownloader.org/Know...le-deepdecrypt
https://support.jdownloader.org/Know...ple-directhttp
https://support.jdownloader.org/Know...followredirect
https://support.jdownloader.org/Know...xample-rewrite

Originally Posted by StefanM

I just wanted to share some of my experience with you, to help you, to give you at least something back. That's all.

No worries.

Originally Posted by StefanM

Just take a lot at some User's Manuals, maybe of your TV, your Stereo, your automatic lawnmower, whatsoever. If it is no a 'cheap' Chinese product, you will notice, that in each chapter (how to do this, how to do that,...) you will find references:

Yes but we are neither of both:
It's a free software and there is no time to polish those articles to a commercial level.
You're free to do so though I'm not sure if we can give you access to modifying articles yourself.

Originally Posted by StefanM

That's all I wanted to tell you.

I still disagree but as explained, you're free to do so.

I'm off into the weekend.
See you next week.

[BillyCool]

Hi there,

Not sure if this is the right place to report an issue with EV, but after updating today, none of my scripts are working anymore. This is the exception trace:

net.sourceforge.htmlunit.corejs.javascript.EvaluatorException: Java class "org.jdownloader.extensions.eventscripter.sandboxobjects.ScriptEnvironment" has no public instance field or method named "getPathSeparator". (#1)
	at net.sourceforge.htmlunit.corejs.javascript.DefaultErrorReporter.runtimeError(DefaultErrorReporter.java:71)
	at net.sourceforge.htmlunit.corejs.javascript.Context.reportRuntimeError(Context.java:1047)
	at net.sourceforge.htmlunit.corejs.javascript.Context.reportRuntimeError(Context.java:1094)
	at net.sourceforge.htmlunit.corejs.javascript.Context.reportRuntimeError2(Context.java:1068)
	at net.sourceforge.htmlunit.corejs.javascript.JavaMembers.reportMemberNotFound(JavaMembers.java:823)
	at net.sourceforge.htmlunit.corejs.javascript.NativeJavaClass.get(NativeJavaClass.java:100)
	at org.jdownloader.scripting.JSHtmlUnitPermissionRestricter$SandboxWrapFactory$1.get(JSHtmlUnitPermissionRestricter.java:231)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptableObject.getProperty(ScriptableObject.java:2296)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.getObjectProp(ScriptRuntime.java:1477)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.getObjectProp(ScriptRuntime.java:1471)
	at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpretLoop(Interpreter.java:1241)
	at script(:1)
	at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpret(Interpreter.java:798)
	at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.call(InterpretedFunction.java:105)
	at net.sourceforge.htmlunit.corejs.javascript.ContextFactory.doTopCall(ContextFactory.java:411)
	at org.jdownloader.scripting.JSHtmlUnitPermissionRestricter$SandboxContextFactory.doTopCall(JSHtmlUnitPermissionRestricter.java:134)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:3057)
	at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.exec(InterpretedFunction.java:115)
	at net.sourceforge.htmlunit.corejs.javascript.Context.evaluateString(Context.java:1212)
	at org.jdownloader.scripting.JSHtmlUnitPermissionRestricter.evaluateTrustedString(JSHtmlUnitPermissionRestricter.java:314)
	at org.jdownloader.extensions.eventscripter.ScriptThread.evalTrusted(ScriptThread.java:325)
	at org.jdownloader.extensions.eventscripter.ScriptThread.initEnvironment(ScriptThread.java:296)
	at org.jdownloader.extensions.eventscripter.ScriptThread.executeScipt(ScriptThread.java:177)
	at org.jdownloader.extensions.eventscripter.ScriptThread.run(ScriptThread.java:160)

After troubleshooting a little bit, even a completely blank script returns this error upon doing a test run. Any ideas?

EDIT: I should add, I last updated the day before and had no issues then, so one of the more recent updates did something.

[Jiaz]

@BillyCool: update is already on the way, wait 2-5 mins and hit update button

[BillyCool]

@Jiaz: Thank you so much for the speedy response once again, updated just now and can confirm everything is working again!

[Jiaz]

@BillyCool: Thanks for the feedback and sorry for the inconvenience

[StefanM]

@mgpai

Script causes error:

/*
    New Core Revision Notification
    Trigger : JDownloader started
*/

var list = "";
var file = JD_HOME + "/revisions.txt";
var revision = callAPI("jd", "getCoreRevision");

try {
    list = readFile(file);
} catch (e) {};

if (list.indexOf(revision) == -1) {
    writeFile(file, revision + "\r\n", true);
    alert("" + revision);
}

First real live test with a new core update.
On JD restart I'm getting this error message:



In test run it works fine!

What's wrong?

In case you need them, I also copied the details to a file.

[mgpai]

Originally Posted by StefanM

What's wrong?

Was caused by a recent update. Has been fixed by @Jiaz. Update JD (if you haven't already).

[StefanM]

Originally Posted by mgpai

Was caused by a recent update. Has been **External links are only visible to Support Staff**... by @Jiaz. Update JD (if you haven't already).

looks god now. Thank you!

[excidius]

Does someone know how to check if the download folder for a package is something in particular.. if so, it will run a script??
like

if (link.getDownloadPath == "/incoming/folder") {
callSync("sh", "/usr/bin/scriptname");
}

Obviously wrong.. But I'm not sure what to use.

[mgpai]

Originally Posted by excidius

But I'm not sure what to use.

link.getDownloadPath returns the full path (folder + filename). Also, the syntax is incorrect. Should be link.getDownloadPath().

To get only the download folder use:

link.getPackage().getDownloadFolder()

[Jiaz]

@StefanM:
you either explicit call a method, for example

link.getPackage()

or by use of property name

link.package

[excidius]

I get a TypeError: Cannot call method "getDownloadFolder" of null (#2)
When i tried:

if (link.getPackage().getDownloadFolder() == "/incoming/folder") {
callSync("sh", "/usr/bin/command");
}

Sorry guys. I'm an idiot when it comes to this stuff.

[Jiaz]

@excidius: what event trigger? or on *test run*?
you have to check for getPackage() != null eg

if (link.getPackage() && link.getPackage().getDownloadFolder()...

[excidius]

The event trigger was when package is completed.

[Jiaz]

@excidius: thanks for the feedback! have you setup JDownloader to auto remove finished links/packages?

[mgpai]

Originally Posted by excidius

The event trigger was when package is completed.

"Package finished" trigger does not return 'link' object. You have to use:

package.getDownloadFolder()

[Jiaz]

Originally Posted by mgpai

"Package finished" trigger does not return 'link' object. You have to use:

package.getDownloadFolder()

good catch but I still wonder why the null pointer happens on
getDownloadFolder and not on getPackage then.